fix: preserve guarded sample lifecycle - #1466
Merged
Merged
Conversation
Jammy2211
marked this pull request as ready for review
August 11, 2026 16:46
This was referenced Aug 11, 2026
2 tasks
Jammy2211
pushed a commit
to trexfr-ops/PyAutoFit
that referenced
this pull request
Aug 27, 2026
…PyAutoLabs#1486) `Samples.instances` and the shared `to_instance` decorator materialized stored samples with no `FitException` recovery, so results written before a model's constructor validation tightened raise from deep inside instance construction (PyAutoFit#1486; workspace half shipped as autogalaxy_workspace#210). - `to_instance` gains a per-method recovery policy: `max_log_posterior` falls back to the next valid stored sample (mirroring the PyAutoLabs#1466 `max_log_likelihood` guard via a shared helper); `from_sample_index` and the marginalized methods raise a typed `SamplesException` chained to the rejection, since they have no valid stored sample to substitute. - `Samples.instances` skips rejected stored samples with a warning, reusing `valid_sample_instance_pairs` (PyAutoLabs#1470). - The mode-1 rejected-final-sample hook and the updater's samples-save guard catch the new wrapped type. BREAKING: reconstruction failures from `to_instance`-decorated methods now surface as `SamplesException` instead of `ModelParameterException`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the new model-parameter guards, while making every stored-sample consumer treat guard failures as rejected historical points instead of fatal infrastructure errors.
This addresses the two independent regressions behind the blocked nightlies:
SamplesPDF, losing the original sampler type, metadata, and factor-graph/per-analysis model structure.Changes
samples.model, the concrete samples class, andsamples_infowhen test-mode recovery replaces a rejected final sample.FitException, with a bounded attempt limit and a clearSamplesExceptionif no valid point exists.FitException-invalid points in weighted aggregator replay while keeping samples and weights aligned.FitException; unrelated programming errors still propagate.The PyAutoGalaxy guards themselves are unchanged.
Regression coverage
Adds coverage for:
FitExceptionerrorsValidation
git diff --check: clean